fix: try to decode hex encoded md5 hash during pw migration #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
commented
Feb 3, 2025
| } | ||
|
|
||
| // The hash is a hex encoded string, so we return the decoded hash. | ||
| return nil, nil, passedHash, nil | ||
| case 5: |
There was a problem hiding this comment.
I am not sure if this needs to be done in the salted version of this hash as well. I am not familiar with that format at all, and not sure what applications would generate this form.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4287 +/- ##
==========================================
- Coverage 78.58% 78.57% -0.01%
==========================================
Files 381 381
Lines 27370 27375 +5
==========================================
+ Hits 21509 21511 +2
- Misses 4238 4241 +3
Partials 1623 1623 ☔ View full report in Codecov by Sentry. |
|
See #3310 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're passing the byte value encoded as base64 directly, e.g.
base64(md5("password")), to the comparison function. Some people would expect, that the value of md5("password") is hex encoded before it is encoded as base64, e.g.base64(hex(md5("password").AFAICT, PHP's
md5function implements the hex based approach, which is where the confusion is coming from, I assume. Other implementations seem to be generating the hash without first encoding the md5 digest as hex.Related issue(s)
Closes #3310
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments